Skip to content

Conversation

pwseg
Copy link
Contributor

@pwseg pwseg commented Aug 9, 2022

Proposed changes

  • Removed menu anchor link that pointed to deprecated Google Sheet Tracking Plan.
  • Removed a few exclamation points and first-person plural uses.

Merge timing

  • ASAP once approved.

Miscellaneous

A section that begins on Line 138 contains several first-person plural references. I've left them in for now, because it's an odd case that talks about how Segment's internal team solved a use case. I'm considering ways to fix that, but I'm not sure if replacing every instance of we with Segment makes sense. For now, I've left it in, but I plan to revisit it later.

@pwseg pwseg added the fixed-content fix to content that has outdated or wrong information label Aug 9, 2022
@pwseg pwseg requested a review from a team as a code owner August 9, 2022 02:23
@pwseg pwseg requested review from stayseesong and removed request for a team August 9, 2022 02:23
@pwseg pwseg merged commit 1ca478a into develop Aug 9, 2022
@pwseg pwseg deleted the tracking-plan-template-fix branch August 9, 2022 17:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants