Skip to content

Remove </img> from Typewriter page #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

Remove </img> from Typewriter page #347

merged 1 commit into from
Nov 26, 2019

Conversation

colinking
Copy link
Contributor

Fixes this: https://segment.com/docs/protocols/typewriter/#api-token-configuration

Proposed changes

Removes this </img. Guess img tags don't need to close themselves 🤔

image

XavierAgostini
XavierAgostini approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@XavierAgostini XavierAgostini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinking colinking merged commit 0a0e0cc into master Nov 26, 2019
@colinking colinking deleted the colin/fix-img branch November 26, 2019 00:29
bot-docsteam added a commit that referenced this pull request May 3, 2022
@bot-docsteam
Merge pull request #347 from segmentio/repo-sync
ec672a5 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierAgostini XavierAgostini XavierAgostini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinking @XavierAgostini