Skip to content

Partner Docs Hackathon #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Dec 10, 2019
Merged

Partner Docs Hackathon #377

merged 22 commits into from
Dec 10, 2019

Conversation

misteryeo
Copy link
Contributor

Proposed changes

  • Polished up all docs content with primary focus on Subscriptions as that's the only available component currently. Did a once over of Plugins as well. Streams have remained as is.
  • Consolidated reused content into a higher level doc.
  • Moved FAQs into it's own doc.
  • Updated sidenav and folder structure. @sanscontext wasn't able to see the sidenav updated locally still but you had asked me to push up for you to take a look.
  • Updates call-outs where appropriate.

Content review from @n2parko and docs structure review from @sanscontext requested.

sanscontext
sanscontext reviewed Nov 27, 2019
View reviewed changes
src/partners/faqs.md Outdated
@@ -0,0 +1,73 @@
---
title: FAQs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this more specific just for the page title? "Partners FAQ"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it 🤔

sanscontext
sanscontext reviewed Nov 27, 2019
View reviewed changes
src/partners/index.md Outdated
@@ -1,10 +1,14 @@
---
title: Join the Segment Platform
title: Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Partners section has its own "microsite" so the old title is preferred here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@sanscontext sanscontext mentioned this pull request Nov 27, 2019
Closed
@sanscontext
Copy link
Contributor

I can't get this working either unfortunately. :( I've filed an issue so Tonik can look into it.

@sanscontext sanscontext self-requested a review December 10, 2019 19:00
sanscontext
sanscontext approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want these changes to get stuck waiting for small stuff - we can merge these and refine later. But the titles of the pages need some tweaks.

@misteryeo misteryeo merged commit de19fb6 into master Dec 10, 2019
@misteryeo misteryeo deleted the partner-docs-edit branch December 10, 2019 21:03
bot-docsteam added a commit that referenced this pull request May 17, 2022
@bot-docsteam
Merge pull request #377 from segmentio/repo-sync
4b020d0 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanscontext sanscontext sanscontext approved these changes

@n2parko n2parko Awaiting requested review from n2parko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misteryeo @sanscontext