Update S3 Source to be EU compatible #3946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mericsson
commented
Dec 13, 2022
mericsson
commented
Dec 14, 2022
mericsson
requested review from
markzegarelli
and removed request for
a team
mericsson
commented
Dec 14, 2022
mericsson
commented
Dec 14, 2022
mericsson
commented
Dec 14, 2022
| // host: "https://events.eu1.segmentapis.com" | ||
| // }); | ||
| // var objects = new Objects(process.env.write_key, { | ||
| // host: "http://objects.euw1.segment.com" |
There was a problem hiding this comment.
@mericsson Should we ship these two together? Or are the ok to go out individually?
There was a problem hiding this comment.
OK to ship individually
markzegarelli
approved these changes
Dec 15, 2022
markzegarelli
added
the
content-update
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update documentation for S3 Source for EU regional customers on page https://segment.com/docs/connections/sources/catalog/cloud-apps/amazon-s3/
Merge timing
ASAP once approved
Related issues (optional)
https://segment.atlassian.net/browse/LIBWEB-1303