Skip to content

June Actions segment docs #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Conversation

ferrucc-io
Copy link
Contributor

@ferrucc-io ferrucc-io commented Apr 3, 2023

Proposed changes

Adding in documentation for the June Actions destination

Merge timing

Whenever it's approved!

Related issues (optional)

title: June (Actions) Destination
hide-boilerplate: true
hide-dossier: false
id: ????
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the ID be here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id: 6419fce5b6e12cf44efbd34c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stayseesong
Copy link
Contributor

@ferrucc-io would you be able to incorporate the edits I suggested? Thank you!

ferrucc-io and others added 10 commits April 7, 2023 17:54
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
@ferrucc-io
Copy link
Contributor Author

@stayseesong it should be good to go now!

@ferrucc-io ferrucc-io requested a review from stayseesong April 10, 2023 19:03
ferrucc-io and others added 2 commits April 10, 2023 20:04
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @markzegarelli and @ferrucc-io,

I just had a quick read through the doc, as I was the person who assisted @ferrucc-io with the PR when he was building the Integration.

I just have a couple of comments/questions which have been left inline.

Comment on lines +35 to +41
{% capture group_identify_user_details %}

In the default configuration, June (Actions) triggers this action when it receives a Group call.

This action sets or updates the properties of specific groups. Use this when you want to update properties on a June company profile.

{% endcapture %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markzegarelli , what does this block do? i.e everything in the 'capture'? What will it render on the page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-ayoub-segment Sorry for the delay here.

This block is what I mentioned before, about trying to inject content into the rendered actions section. The idea here, is that everything being captured will render where it's referenced. However, this is pretty prone to error, so I think this will be a good use case for adding content to the docs_description object in the code.


### Connection modes for June (Actions) destination

The June (Actions) destination does not offer a device-mode connection mode. If you're using one of Segment's new libraries ([Analytics.js 2.0](/docs/connections/sources/catalog/libraries/website/javascript/){:target="_blank"}, [Swift](https://github.com/segmentio/analytics-swift){:target="_blank"} or [Kotlin](https://github.com/segmentio/analytics-kotlin){:target="_blank"}) with the Actions-framework version of the destination, you do not need the device-mode connection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this line is confusing.

@markzegarelli Is this boiler plate?

I'm wondering is something along the lines of:
"The June (Actions) destination does not offer a device-mode connection mode, so all events generated on a browser or mobile app will be sent to June's servers via Segment's servers."

Or maybe I'm missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-ayoub-segment I believe this comes from the idea that Actions are cloud-mode only, but I could be mistaken. This is not boiler plate.

Your proposal does clean things up.

@joe-ayoub-segment
Copy link
Contributor

@markzegarelli , the docs look to match what was designed. Can you take the PR from here please?

@markzegarelli
Copy link
Contributor

@markzegarelli , the docs look to match what was designed. Can you take the PR from here please?

Yes, we'll take it from here!

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
@ferrucc-io ferrucc-io requested a review from a team as a code owner April 19, 2023 09:08
joe-ayoub-segment

This comment was marked as resolved.

@tcgilbert
Copy link
Contributor

@markzegarelli - June is ready for their integration to go in Public Beta. Is there anything outstanding I can assist with? Or will we be able to get this live tomorrow?

@markzegarelli
Copy link
Contributor

I've opened #4610 to allow us to add content to the PR, as we can't push to this branch. Closing this, and will deploy #4610 tomorrow.

@ferrucc-io
Copy link
Contributor Author

Awesome lmk if you need anything else from my end - happy to support 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants