Fix integration slugs #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanscontext
reviewed
Dec 17, 2019
scripts/catalog.js
Outdated
| .toLowerCase() | ||
| .replace(/\s+/g, '-') | ||
| .replace('-&-', '-') | ||
| .replace('/', '-') | ||
| .replace(/[\(\)]/g, '') | ||
| .replace('.','-') | ||
|
|
||
|
|
||
| if (slug === 'active-campaign') slug = 'activecampaign' | ||
| if (slug === 'adwords') slug = 'google-ads' |
There was a problem hiding this comment.
I think this needs to be google-ads-classic?
sanscontext
suggested changes
Dec 17, 2019
|
Hey @XavierAgostini , when I run |
sanscontext
approved these changes
Jan 18, 2020
Signed-off-by: sanscontext <lrubin@segment.com>
|
Closing this out per discussion - we do want to keep the display-name the slugified part, and move docs to match a rename. I'm going to go through and make sure that all the correct things are doing the right stuff in the docs, then make sure that the links to docs, as explained in the Partner Portal, are linking to the right thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
Fixes #406