Skip to content

update typewriter docs #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2023
Merged

update typewriter docs #4664

merged 2 commits into from
May 1, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Apr 28, 2023

No description provided.

@silesky silesky requested a review from forstisabella as a code owner April 28, 2023 22:10
@silesky silesky changed the title update typewriter update typewriter docs Apr 28, 2023
@silesky silesky requested a review from oscb April 28, 2023 22:14
@silesky silesky force-pushed the update-typewriter branch from 2835111 to dc61dcf Compare April 29, 2023 18:37
@silesky silesky force-pushed the update-typewriter branch 3 times, most recently from 984122d to eb08d40 Compare April 29, 2023 18:40
rchinn1
rchinn1 requested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silesky looks good - just two suggested changes for your review.

silesky and others added 2 commits May 1, 2023 14:15
@silesky
update typewriter
e3c4c24
@silesky @rchinn1
Update src/protocols/apis-and-extensions/typewriter.md
465cc2c 
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@silesky silesky force-pushed the update-typewriter branch from 60fb931 to 465cc2c Compare May 1, 2023 19:15
@silesky silesky requested a review from rchinn1 May 1, 2023 19:17
@rchinn1 rchinn1 added the content-update updates to content that are not new features, includes grammar fixes, added notes label May 1, 2023
@silesky silesky merged commit 3e20a5b into develop May 1, 2023
@silesky silesky deleted the update-typewriter branch May 1, 2023 22:48
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchinn1 rchinn1 rchinn1 approved these changes

@forstisabella forstisabella Awaiting requested review from forstisabella forstisabella is a code owner

@oscb oscb Awaiting requested review from oscb

@markzegarelli markzegarelli Awaiting requested review from markzegarelli

@pwseg pwseg Awaiting requested review from pwseg

Assignees
No one assigned
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silesky @rchinn1