Skip to content

Added information that the Engage generated source should not be disabled #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023

Conversation

tanjinhong72
Copy link
Contributor

Proposed changes

Added information that the source should not be disabled also. As there were tickets where customers disabled these sources and result in audiences/traits not synching to destinations.

Original sentence:
This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Added "and should not be disabled" and modified to:
This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Merge timing

Related issues (optional)

https://segment.zendesk.com/agent/tickets/506372

Added information that the source should not be disabled also.

Original sentence:
This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Added "and should not be disabled" and modified to:
This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.
@tanjinhong72 tanjinhong72 marked this pull request as ready for review May 8, 2023 09:19
@tanjinhong72 tanjinhong72 requested a review from rchinn1 as a code owner May 8, 2023 09:19
@rchinn1 rchinn1 merged commit 5432380 into develop May 8, 2023
@rchinn1 rchinn1 deleted the tanjinhong72-patch-2 branch May 8, 2023 18:24
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants