Skip to content

Fix broken link to Braze Destination Plugin #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

ashton-huxtable
Copy link
Contributor

Proposed changes

Fixed a broken link to the Braze destination plugin

Merge timing

  • ASAP once approved

Related issues (optional)

n/a

@ashton-huxtable ashton-huxtable marked this pull request as ready for review June 6, 2023 21:22
@ashton-huxtable ashton-huxtable requested a review from a team as a code owner June 6, 2023 21:22
@ashton-huxtable ashton-huxtable requested review from stayseesong and alanjcharles and removed request for a team and stayseesong June 6, 2023 21:22
Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ashton!

@ashton-huxtable ashton-huxtable requested review from a team and markzegarelli and removed request for a team June 6, 2023 21:31
@markzegarelli markzegarelli merged commit 6643dd0 into develop Jun 8, 2023
@markzegarelli markzegarelli deleted the ashton-huxtable-patch-1 branch June 8, 2023 17:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request Jun 8, 2023
* Update common.md

* update

* missing quotes

* Update src/connections/spec/common.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Update src/connections/spec/common.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Update src/connections/sources/catalog/libraries/website/javascript/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* [netlify-build]

* Fix link [netlify-build]

* Update install instructions to new braze sdk

* Update src/connections/sources/catalog/libraries/website/javascript/index.md

* ios-faqs - AppClip

* Update custom-proxy.md (Warning Box)

The last sentence is a fragment. "When you enable third-party libraries in device-mode, Segment loads them, which defeats the purpose of self-hosting. Self-hosting Analytics.js requires" 

I've removed the last sentence: 

"Self-hosting Analytics.js requires" As this is a fragment and has not been completed.

* Moved the existing Friendbuy source docs into the friendbuy-legacy fo… (#4835)

* Moved the existing Friendbuy source docs into the friendbuy-legacy folder (which already existed and has hidden set to true). Updated the friendbuy source docs. They are ready for review.

* converting html tables to markdown

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/cloud-apps/friendbuy/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Update src/connections/sources/catalog/libraries/mobile/ios/ios-faqs.md

* Multiple destination instance update (#4856)

* Multiple destination instance update

* Apply suggestions from code review

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* Fix broken link to Braze Destination Plugin (#4848)

* catalog update

---------

Co-authored-by: dsjackins <daniel.jackins@segment.com>
Co-authored-by: Daniel Jackins <danieljackins@gmail.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: Ashton Huxtable <78318468+ashton-huxtable@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com>
Co-authored-by: Peter Cooper <113425933+PcooperSegment@users.noreply.github.com>
Co-authored-by: James Reynolds <jameshreynolds@gmail.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants