Skip to content

canny #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2020
Merged

canny #489

merged 2 commits into from
Jan 7, 2020

Conversation

pauljaeinyoo
Copy link
Contributor

added new Developer Center integration, Canny, docs

@pauljaeinyoo
Copy link
Contributor Author

@sanscontext let me know if there's anything preventing from this being merged by the end of the day!(:

sanscontext
sanscontext suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few changes, otherwise looks okay.

We're also pulling the Settings info programmatically so that section might not be needed.

@pauljaeinyoo
Copy link
Contributor Author

hey @sanscontext does everything look good? so sorry to be a bother, but the customer really wants to be launched by the end of the day!

sanscontext
sanscontext approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now. We'll need to remove the Settings part later since that's usually programmatically built.

@pauljaeinyoo pauljaeinyoo merged commit caa175a into master Jan 7, 2020
@pauljaeinyoo pauljaeinyoo deleted the canny branch January 7, 2020 00:37
bot-docsteam added a commit that referenced this pull request Jul 21, 2022
@bot-docsteam
Merge pull request #489 from segmentio/repo-sync
33109aa 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sanscontext sanscontext sanscontext approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauljaeinyoo @sanscontext