fix(feedback): Disable all buttons based on click on no matter which … #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question - will this disable some of the link-type buttons as well, or just the feedback specific ones? We have a few links at the bottom (the support form, and the docs-feedback mail to link) which are also technically “buttons” so I want to make sure those still work. |
|
@sanscontext I understand your concern about this one, my "disable all buttons" could be confusing. This will disable all buttons but with a specific data attribute, so basically just feedback buttons, other links are safe :) |
|
Perfect! Thank you! |
sanscontext
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #516