Add note on connecting new mappings to model #5344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyatsegment
requested review from
rchinn1
and removed request for
a team
rchinn1
approved these changes
Sep 19, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add note to clarify that currently, connection between reverse ETL model and mapping should be one:one to sync an entire dataset, otherwise only the diffs will sync.
Relevant Slack thread: https://twilio.slack.com/archives/C03NK2Y2GTC/p1685476363083219
"with the current design - any subsequently added mappings/destinations to an existing model will only sync the diffs. For now, customers should recreate the model and then add a mapping/destination (e.g. one model to one mapping) to sync all the data."
Merge timing
Related issues (optional)