Add herow source #552
Add herow source #552
Conversation
src/_data/catalog/sources.yml
Outdated
| @@ -285,6 +285,19 @@ items: | |||
| url: '' | |||
| categories: | |||
| - Server | |||
| - display_name: Herow | |||
There was a problem hiding this comment.
Was this pulled using make catalog?
There was a problem hiding this comment.
Ahh did not realize the correct way to do this. This is a dev center source (currently have it set to private): https://app.segment.com/partner-portal/source/herow/json
I was thinking it might be best to merge the docs and then do a separate pr for the catalog update. Thinking that the customer can view the docs via the URL (sort of private beta) and then we can set it "live" via the catalog update. But perhaps that is not how this works. Totally open to suggestions on the preferred way to do this :)
There was a problem hiding this comment.
We categorically do not publish docs for private beta partners, because we can't see them in the catalog. If they're ready to switch to public beta, then we can publish them.
There was a problem hiding this comment.
Hey @sanscontext , Think i confused up this pr kinda badly. Happy to close this and create a new one if that helps.
Soooo, the reason this was initially set to private is because it's part of a stream dev center review. Basically we paste in some json to the dev center to and that's how a stream is created. I set this to private initially to make sure it works. I'll avoid this workflow going forward.
I have now set to live and updated the catalog (hence extra files for review). Thanks!
| @@ -0,0 +1,146 @@ | |||
| # HEROW | |||
There was a problem hiding this comment.
Hey, please look at other docs in this corpus and match the style. This needs at minimum the title: frontmatter set and this line removed.
There was a problem hiding this comment.
Added the title, is there any more markup missing? For context this is partner created from this template: https://hackmd.io/TV8cZR6tRnKwGtkvSexeag?both
I have asked for edit access to amend the template but it would be great to get this right at source.
There was a problem hiding this comment.
I think the idea was that we were supposed to add that frontmatter and they'd get confused by it, or possibly that it was in the runbook? But at minimum you need title: and for most of these you might also need beta: true.
There was a problem hiding this comment.
Oh cool, I added the beta flag now too.
|
|
||
| With HEROW simple, straightforward SaaS platform, mobile marketers and developers can: | ||
|
|
||
| + Better understand how, when and where their app is being used |
There was a problem hiding this comment.
Do you know what's going on with the spacing here? 🤔
There was a problem hiding this comment.
Didn't spot as it renders fine, but now removed.
|
I think you can actually remove the updated catalog file - Xav was kind enough to add some sorting to it, so it got regenned today as part of that change. :) Otherwise, I just want to make sure that the tables render correctly, and then I think as long as its in public beta, you're good? |
niallzato
force-pushed
the
niallb/add_herow_source
branch
from
b2e4d3f to
ac6c7a7
Compare
|
|
||
| [HEROW](https://www.herow.io) is a contextual platform for mobile application. Built around everyday behaviors and powered by location intelligence, its one-stop solution allows apps to maximize mobile engagement with their users. | ||
|
|
||
| With HEROW simple, straightforward SaaS platform, mobile marketers and developers can: |
There was a problem hiding this comment.
Lines 9 through 17 are marketing content and don't belong in the docs. 🤔 Lets please remove these.
There was a problem hiding this comment.
Removed the marketing content, we good to approve and merge 🤞
Proposed changes
Reviewing and setting the Herow source live.
Included the Markup document.
Edited the sources.yml file, not too sure if this required though.
https://segment.zendesk.com/agent/tickets/365689
https://segment.atlassian.net/wiki/spaces/DC/pages/347111764/Herow+-+Private+Building