Catalog troubleshooting #581
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Trying to prevent the
isCatalogItemHidden
function from barfing if there's no file. This seems to be a race condition (?!) when checking to see if the file exists? My changes in this PR prevent the "create file" part from running, but at least unblocksmake catalog
- I might be using the wrong (sync vs async?) file system method here.Related issues (optional)
Closes #568
(hopefully)