Skip to content

Privacy Portal docs improvements #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

muhammadatifjav
Copy link
Contributor

Proposed changes

  • Moved Privacy detection to top to make it consistent with how these are ordered in Segment app.
  • Added details about classifications and their impact
  • Renamed "Symbol Name" to "Matcher Name" to make it consistent with UI.
  • Replaced screenshot as UI issue has been fixed https://segment.atlassian.net/browse/PROT-5007

Merge timing

  • ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/PROT-5007
https://segment.atlassian.net/browse/KCS-745

- Moved Privacy detection to top to make it consistent with how these are ordered in Segment app.
- Added details about classifications and their impact
- Renamed "Symbol Name" to "Matcher Name" to make it consistent with UI.
Delete old screenshot src/privacy/images/privacy-synonym-in-matcher.png
@muhammadatifjav muhammadatifjav marked this pull request as ready for review January 17, 2024 05:45
@muhammadatifjav muhammadatifjav requested a review from a team as a code owner January 17, 2024 05:45
@muhammadatifjav muhammadatifjav requested review from pwseg and removed request for a team January 17, 2024 05:45
@pwseg pwseg added content When the bug is about content that needs to get fixed content-update updates to content that are not new features, includes grammar fixes, added notes and removed content When the bug is about content that needs to get fixed labels Jan 18, 2024
@pwseg pwseg changed the title Atif privacy portal docs improvements Privacy Portal docs improvements Jan 18, 2024
@pwseg pwseg merged commit 6bdf559 into develop Jan 18, 2024
@pwseg pwseg deleted the atif-privacy-portal-docs-improvements branch January 18, 2024 18:02
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants