Skip to content

Enable with segment- token endpoint #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Conversation

kellymtrinh
Copy link
Contributor

@kellymtrinh kellymtrinh commented Feb 14, 2020

Proposed changes

Adding details for how to correctly call the token exchange endpoint. We don't mention that you need to put the client secret and ID in a basic authorization header. The library we use in our partnerapp demo does this.

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Co-Authored-By: LRubin <sanscontext@users.noreply.github.com>
@kellymtrinh kellymtrinh merged commit fc78ec2 into master Feb 14, 2020
@sanscontext sanscontext deleted the kelly/update-oauth-docs branch February 14, 2020 23:45
bot-docsteam added a commit that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants