Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Moloco MCM destination beta doc #6399

Merged
merged 37 commits into from
Apr 25, 2024

Conversation

samir-moloco
Copy link
Contributor

Proposed changes

Adds the documentation for our platform's Segment Destination (Moloco MCM).

Merge timing

  • ASAP once approved

@samir-moloco samir-moloco requested a review from a team as a code owner April 17, 2024 00:53
@samir-moloco samir-moloco requested review from forstisabella and removed request for a team April 17, 2024 00:53
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 7f034cb
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/661f1d7ac06bad0008553d39
😎 Deploy Preview https://deploy-preview-6399--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@forstisabella forstisabella added the new-integration Added a new source or destination label Apr 17, 2024
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding alternatives to your screenshots!

If you have any questions or comments about my review, please feel free to tag me in a comment!

src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved

In the mappings tab, some fields are chosen by default if some common fields map to Moloco Event’s fields. If the mapped key does not exist in the input data, it won’t trigger an error and will just not pass any value.

If you are using **the default fields in a custom way**, please confirm that your mapping meets Moloco's requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might need more context on this: what would using the default fields in a custom way look like? Where could a user read more about Moloco's requirements?

src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
samir-moloco and others added 10 commits April 21, 2024 16:04
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
samir-moloco and others added 5 commits April 22, 2024 04:31
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Once a user is identified, each call to Segment's [Track method](/docs/connections/spec/track/) automatically records the user ID.
Users that are not logged in can be tracked using an [anonymousID](/docs/connections/spec/identify/#anonymous-id). Moloco Commerce Media does not use anonymousIDs for users that are not logged in. Segment recommends formatting your anonymousID in UUID format.

> info" "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> info" "
> info " "

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! after it gets approval from @tcgilbert we'll be good to go.

Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. add the requested snippet (this will autopopulate details about each action and it's field in your docs
  2. you need to rename the folder name from moloco-rmp to actions-moloco-rmp as the slug of your integration is used to autogenerate links out to your docs from other parts of our application

src/connections/destinations/catalog/moloco-rmp/index.md Outdated Show resolved Hide resolved
@samir-moloco
Copy link
Contributor Author

samir-moloco commented Apr 25, 2024

Two things:

  1. add the requested snippet (this will autopopulate details about each action and it's field in your docs
  2. you need to rename the folder name from moloco-rmp to actions-moloco-rmp as the slug of your integration is used to autogenerate links out to your docs from other parts of our application

Done!

@samir-moloco samir-moloco reopened this Apr 25, 2024
@forstisabella forstisabella merged commit cef43b3 into segmentio:develop Apr 25, 2024
5 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@samir-moloco
Copy link
Contributor Author

Hi team, I could find the doc to this URL (https://segment.com/docs/connections/destinations/catalog/actions-moloco-rmp/) but it is not indexed and listed in https://segment.com/docs/connections/destinations/catalog
How can we make sure it's listed in the list of destination and categorised under advertising?

@forstisabella
Copy link
Contributor

Hi @samir-moloco: the private: true attribute in the frontmatter of this document makes it only accessible by direct link and keeps the page from being indexed + listed in autogenerated content on segment.com/docs, like the destinations catalog you linked! When the Moloco RMP integration enters public beta we will remove that attribute and it will populate into our autogenerated content.

@tcgilbert - is there a way to tell which categories this destination will populate into? I can't see anything in PAPI!

@tcgilbert
Copy link
Contributor

@samir-moloco can you send me your email address?

Essentially, the last step you need to complete to get your destination live is to add the integrations catalog metadata in our developer portal. This is where you will select categories, add logos, etc. Once done, and your integration is in public beta, the docs will populate correctly.

@samir-moloco
Copy link
Contributor Author

@samir-moloco can you send me your email address?

Essentially, the last step you need to complete to get your destination live is to add the integrations catalog metadata in our developer portal. This is where you will select categories, add logos, etc. Once done, and your integration is in public beta, the docs will populate correctly.

@tcgilbert my email address is samirh@moloco.com
Not sure if I have access to that developer portal. Maybe should I sync with the eng team that built the Moloco destination on Segment?

@tcgilbert
Copy link
Contributor

tcgilbert commented Apr 30, 2024

@samir-moloco I just sent a developer portal invitation to your email address, as well as heonjang.lee@moloco.com. Once accepted, you should be able to access the developer portal here: https://app.segment.com/dev-portal/overview.

Please ensure you're logged into a Segment account associated with the same email address to which the invitation was sent (You may have to create your segment account). In case you use a Segment account tied to a different email address, just let me know, and I'll send an invitation to the correct address.

@samir-moloco
Copy link
Contributor Author

@samir-moloco I just sent a developer portal invitation to your email address, as well as heonjang.lee@moloco.com. Once accepted, you should be able to access the developer portal here: https://app.segment.com/dev-portal/overview.

Please ensure you're logged into a Segment account associated with the same email address to which the invitation was sent (You may have to create your segment account). In case you use a Segment account tied to a different email address, just let me know, and I'll send an invitation to the correct address.

Thanks got the invite but I noticed I previously used samir.hammoudi@moloco.com for my Segment account so would appreciate if you resend an invite to this email address instead, thank you!!
Will work on the dev portal to get what's needed to get to public beta ;)

@samir-moloco
Copy link
Contributor Author

Hi @tcgilbert we did all the required steps on the developer portal and submitted for review to move to public beta. Hopefully this get approved soon. Thanks again for your review on this doc!

@tcgilbert
Copy link
Contributor

hey @samir-moloco - great! looks like we have everything needed on our end to move your destiantion into public beta.

Have you completed testing the Integration, and are confident it behaves as expected? If so, I'll go ahead and make the destination live.

Also just sent another dev portal invite to samir.hammoudi@moloco.com

@samir-moloco
Copy link
Contributor Author

Hi @tcgilbert excellent! yes I have tested the integration and it works great! thanks in advance to making it public beta!!

@tcgilbert
Copy link
Contributor

@samir-moloco

I have gone ahead and made your integration live. Twilio Segment is excited to move your new integration into the Public Catalog! The mappings on your docs page will populate once our docs site rebuilds on Tuesday.

To move out of beta, you can write back into partner-support@segment.com once you have at least one customer using the integration, and you are confident that the beta status is no longer applicable.

If you have any questions or concerns, please let me know

@samir-moloco
Copy link
Contributor Author

@tcgilbert Thank you for promoting our destination to Public Beta!
I waited Tuesday for the docs site to rebuild but it seems like we have a broken link.

I go under https://segment.com/docs/connections/destinations/catalog/#advertising and click on the Moloco MCM destination. I get a 404 instead of getting to https://segment.com/docs/connections/destinations/catalog/actions-moloco-rmp/

Let me know if we miss some configuration or if we should wait for something to rebuild on your side. Thanks!

@tcgilbert
Copy link
Contributor

hey @samir-moloco - thanks for flagging!

I just put in a patch for this. This will be fixed when the site rebuilds tomorrow afternoon.

If there is anything else I can assist with let me know

@samir-moloco
Copy link
Contributor Author

Confirmed it's now fixed, thank you @tcgilbert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants