-
Notifications
You must be signed in to change notification settings - Fork 379
ProfitWell Docs #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProfitWell Docs #641
Conversation
The doc is a little light, otherwise looks okay. One request for a formatting change. |
7365759
to
7d049f3
Compare
Hey @sanscontext, I addressed the issue with the formatting on the note. From what I understand there needs to be an additional file that is also on this PR? I think its the |
That’s correct! |
And am I correct to assume that the catalog files it updates need to be included in this PR? or do I run |
Ideally, run it and check in the updated files as part of this PR. If you run into issues, you can do it afterwards - but the programmatically generated content won't appear until you do. |
Co-Authored-By: LRubin <sanscontext@users.noreply.github.com>
|
||
If you haven't had a chance to review our spec, please take a look to understand what the [Identify method](https://segment.com/docs/spec/identify/) does. An example call would look like: | ||
|
||
```javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a note js
works just fine here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, thought I approved this on day 1!
I don't see anything like this in the Partner Portal btw. |
Partner Portal is a little broken atm or just has a difficulty seeing web-plugin based integration but anyways, the integration can be found using the link directly https://app.segment.com/partner-portal/integration/profitwell/profile |
Hey @sanscontext. I was able to run |
@gezgblack looks good, though I'd expect |
That is correct 😄 I didn't check them in as they were just timestamp changes. It works as expected 😉 |
Nice! Just remember to delete your branch next time. |
Proposed changes
Add ProfitWell docs. ProfitWell has been in private beta and now wishes to transition to public beta. pa
Partner-Portal: https://app.segment.com/partner-portal/integration/profitwell/profile
Zendesk: https://segment.zendesk.com/agent/tickets/369820
If you could please take a look when you get a chance @sanscontext 😄