Skip to content

ProfitWell Docs #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 25, 2020
Merged

ProfitWell Docs #641

merged 8 commits into from
Feb 25, 2020

Conversation

gezgblack
Copy link
Contributor

Proposed changes

Add ProfitWell docs. ProfitWell has been in private beta and now wishes to transition to public beta. pa

Partner-Portal: https://app.segment.com/partner-portal/integration/profitwell/profile
Zendesk: https://segment.zendesk.com/agent/tickets/369820

If you could please take a look when you get a chance @sanscontext 😄

@sanscontext
Copy link
Contributor

The doc is a little light, otherwise looks okay. One request for a formatting change.

@gezgblack
Copy link
Contributor Author

Hey @sanscontext, I addressed the issue with the formatting on the note. From what I understand there needs to be an additional file that is also on this PR? I think its the destinations.yml file which is created as a result of running make catalog. Feel free to correct me. I haven't done this yet, but I'll take a crack at it now.

@sanscontext
Copy link
Contributor

That’s correct! make catalog contacts the config api and updates the catalog files. The destination has to be marked PUBLIC_BETA from PP first or the command will discard the info.

@gezgblack
Copy link
Contributor Author

That’s correct! make catalog contacts the config api and updates the catalog files. The destination has to be marked PUBLIC_BETA from PP first or the command will discard the info.

And am I correct to assume that the catalog files it updates need to be included in this PR? or do I run make catalog after this PR is merged?

@sanscontext
Copy link
Contributor

Ideally, run it and check in the updated files as part of this PR. If you run into issues, you can do it afterwards - but the programmatically generated content won't appear until you do.

Co-Authored-By: LRubin <sanscontext@users.noreply.github.com>

If you haven't had a chance to review our spec, please take a look to understand what the [Identify method](https://segment.com/docs/spec/identify/) does. An example call would look like:

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note js works just fine here :)

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought I approved this on day 1!

@sanscontext
Copy link
Contributor

I don't see anything like this in the Partner Portal btw.

@gezgblack
Copy link
Contributor Author

gezgblack commented Feb 24, 2020

I don't see anything like this in the Partner Portal btw.

Partner Portal is a little broken atm or just has a difficulty seeing web-plugin based integration but anyways, the integration can be found using the link directly https://app.segment.com/partner-portal/integration/profitwell/profile

@gezgblack
Copy link
Contributor Author

Hey @sanscontext. I was able to run make catalog and I've included the destinations.yml change it created. Would you mind checking if it looks good?

@sanscontext
Copy link
Contributor

@gezgblack looks good, though I'd expect make catalog to update four files, not just the destinations.yml one. Just to confirm, there were no changes aside from the timestamp, so I'm guessing you didn't bother checking them in? (Legit, just want to make sure that the catalog update script is working correctly.)

@gezgblack
Copy link
Contributor Author

@gezgblack looks good, though I'd expect make catalog to update four files, not just the destinations.yml one. Just to confirm, there were no changes aside from the timestamp, so I'm guessing you didn't bother checking them in? (Legit, just want to make sure that the catalog update script is working correctly.)

That is correct 😄 I didn't check them in as they were just timestamp changes. It works as expected 😉

@gezgblack gezgblack merged commit 1fb3316 into master Feb 25, 2020
@sanscontext sanscontext deleted the profitwell branch February 25, 2020 18:00
@sanscontext
Copy link
Contributor

Nice! Just remember to delete your branch next time.

bot-docsteam added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants