Acq 2230 productionize docs #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknight12882
suggested changes
Sep 25, 2019
| .PHONY: dev | ||
| dev: node_modules vendor/bundle | ||
| @$(BIN)/concurrently --raw --kill-others -n webpack,jekyll \ | ||
| "$(BIN)/webpack --mode=development --watch" \ | ||
| "bundle exec jekyll serve --trace --incremental -H 0.0.0.0 -V" | ||
|
|
||
| .PHONY: intialize-work-dir | ||
| intialize-work-dir: |
There was a problem hiding this comment.
I don't understand the need for this? _site is a byproduct of make build and @bundle install also happens as part of that step
There was a problem hiding this comment.
there are some permission issues with the Jekyll container, that need to be worked around: envygeeks/jekyll-docker#116
XavierAgostini
force-pushed
the
ACQ-2230-productionize-docs
branch
2 times, most recently
from
187fda8 to
ca60df0
Compare
added 3 commits
October 1, 2019 13:12
squash commits remove chmod command add permission update test workdir change test workdir change test workdir change test workdir change
XavierAgostini
force-pushed
the
ACQ-2230-productionize-docs
branch
from
4488e95 to
58759e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
JIRA: https://segment.atlassian.net/browse/ACQ-2230
Buildkite: https://buildkite.com/segment/segment-docs
Related issues (optional)