Skip to content

Move StackAdapt docs to folder matching slug #6672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

AlliterativeAlice
Copy link
Contributor

Proposed changes

Merge timing

ASAP once approved. I was told the soonest this could be deployed is June 11th.

Related issues (optional)

N/A

@AlliterativeAlice AlliterativeAlice requested a review from a team as a code owner June 5, 2024 22:08
@AlliterativeAlice AlliterativeAlice requested review from forstisabella and removed request for a team June 5, 2024 22:08
@forstisabella forstisabella added the fixed-content fix to content that has outdated or wrong information label Jun 5, 2024
@forstisabella
Copy link
Contributor

forstisabella commented Jun 5, 2024

hi @AlliterativeAlice - when you say that the soonest this can be deployed is June 11, were you referring to the metadata change or the docs? If it's the docs, we can deploy as soon as tomorrow, but if it's the metadata change I'll hold this PR until then.

@AlliterativeAlice
Copy link
Contributor Author

hi @AlliterativeAlice - when you say that the soonest this can be deployed is June 11, were you referring to the metadata change or the docs? If it's the docs, we can deploy as soon as tomorrow, but if it's the metadata change I'll hold this PR until then.

I was referring to deployment of this docs change. I was given the June 11 date by Joe but if we can deploy sooner then that would be preferable.

@forstisabella
Copy link
Contributor

this lgtm - let's get this out today! @AlliterativeAlice

@forstisabella forstisabella merged commit 7d05525 into segmentio:develop Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants