Skip to content

Taboola Action Destination docs #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 24, 2024
Merged

Taboola Action Destination docs #6826

merged 14 commits into from
Jul 24, 2024

Conversation

eden-ohana
Copy link
Contributor

Proposed changes

Taboola Action Destination docs

Merge timing

Related issues (optional)

@eden-ohana eden-ohana requested a review from a team as a code owner July 17, 2024 08:30
@eden-ohana eden-ohana requested a review from cmastr July 17, 2024 08:30
eden-ohana
eden-ohana commented Jul 17, 2024
View reviewed changes
src/connections/destinations/catalog/actions-taboola-actions/index.md Outdated

## Supported identifiers

The **Taboola (Actions)** destination supports syncing Audiences to Taboola using either the `userId` and/or the `Mobile Device ID`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-ayoub-segment Isn't this supposed to be the user's email? Does the user need to configure something for it to be included?

Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eden-ohana yes that's correct! It should be email. Thanks for catching! I've updated it.

Will you be able to complete the rest of the documentation?

cc @smultani

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll finish and let you know when to review.
Thanks!

@eden-ohana
Copy link
Contributor Author

Hi @joe-ayoub-segment ready for review
Thanks

@joe-ayoub-segment
Copy link
Contributor

hi @eden-ohana

  • couple of minor changes needed. After that someone from our Docs cc @cmastr

@joe-ayoub-segment
Copy link
Contributor

hi @cmastr - could someone from the team please review this PR?

@cmastr cmastr requested a review from tcgilbert July 18, 2024 15:34
@cmastr cmastr added the new-integration Added a new source or destination label Jul 18, 2024
tcgilbert
tcgilbert suggested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tcgilbert tcgilbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes to make.

And a couple of things that stood out to me as well:

  • The screenshots submitted show the dev logo. Note that your integration will have the Taboola logo present once you submit your catalog metadata in the developer portal: https://app.segment.com/dev-portal/overview. Not a dealbreaker, but if you want to come back and change these, you can.

  • The name for the destination is currently Taboola (actions), but the standard is to have actions capitalized: Taboola (Actions). Would you like for me to process this name change?

@eden-ohana
Copy link
Contributor Author

A couple changes to make.

And a couple of things that stood out to me as well:

  • The screenshots submitted show the dev logo. Note that your integration will have the Taboola logo present once you submit your catalog metadata in the developer portal: https://app.segment.com/dev-portal/overview. Not a dealbreaker, but if you want to come back and change these, you can.
  • The name for the destination is currently Taboola (actions), but the standard is to have actions capitalized: Taboola (Actions). Would you like for me to process this name change?

@tcgilbert
Could you send me an invitation to join the Segment Developer Portal to add the metadata?

I'd appreciate it if you could make the name change.

Thanks.

@tcgilbert tcgilbert mentioned this pull request Jul 22, 2024
Merged
@tcgilbert
Copy link
Contributor

@tcgilbert Could you send me an invitation to join the Segment Developer Portal to add the metadata?

Looks like you should already have access. Are you able to log into Segment with eden.o@taboola.com, and navigate to the portal here: https://app.segment.com/dev-portal/overview

Screenshot 2024-07-22 at 11 34 58 AM

If your Segment account is associated with a different email address, let me know and I can send an invite to it.

I'd appreciate it if you could make the name change.

Copy that, I've opened a PR for this here: segmentio/action-destinations#2204. No action needed from you

@eden-ohana
Copy link
Contributor Author

Hi @tcgilbert I submitted the metadata for review

@tcgilbert
Copy link
Contributor

@eden-ohana @joe-ayoub-segment

I've approved your catalog info submission, and this metadata will go live along with your integration.

Do you know when you would like to move the integration into Public Beta? We have all the materials needed on our end, so if you are done testing the destination, and are confident it is working as expected, I can go ahead and make the integration live.

@eden-ohana
Copy link
Contributor Author

Hi @tcgilbert
I updated the screenshots with the Taboola logo.
Our beta testers want to start using the integration, and I want to send them the documentation link.
I would appreciate it if we could deploy this PR soon.

Regarding the private or public beta @joe-ayoub-segment, WDYT? I can send the beta users the private link but need the documentation to be public.

Thanks

cmastr
cmastr reviewed Jul 24, 2024
View reviewed changes
@cmastr
Copy link
Contributor

cmastr commented Jul 24, 2024

Added a few grammatical changes.

@eden-ohana eden-ohana requested review from cmastr and tcgilbert July 24, 2024 14:21
tcgilbert
tcgilbert suggested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change from me, other than that looks good

@eden-ohana @tcgilbert
add support email address
fe35516 
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
@eden-ohana eden-ohana requested a review from tcgilbert July 24, 2024 15:05
@eden-ohana
Copy link
Contributor Author

Hi @cmastr can you please review

@cmastr
Copy link
Contributor

cmastr commented Jul 24, 2024

Merging now, will go live on Thursday.

@cmastr cmastr merged commit 9b2c851 into segmentio:develop Jul 24, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmastr cmastr cmastr approved these changes

@tcgilbert tcgilbert tcgilbert approved these changes

@joe-ayoub-segment joe-ayoub-segment Awaiting requested review from joe-ayoub-segment

Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eden-ohana @joe-ayoub-segment @tcgilbert @cmastr