Update allowed PrivateLink CIDR in inbound rules to 10.0.0.0/8 #6849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasadkatti
changed the title
AMeng
previously approved these changes
Jul 23, 2024
AnnieZhao17
reviewed
Jul 23, 2024
msarfaty
reviewed
Jul 24, 2024
Co-authored-by: Mike Sarfaty <113384964+msarfaty@users.noreply.github.com>
msarfaty
previously approved these changes
Jul 24, 2024
AnnieZhao17
previously approved these changes
Jul 24, 2024
forstisabella
previously approved these changes
Jul 24, 2024
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
forstisabella
approved these changes
Jul 24, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, please refer to the conversation in internal Slack - https://twilio.slack.com/archives/C06HE252MK2/p1721744192599429?thread_ts=1719934516.398509&cid=C06HE252MK2
Proposed changes
According to the PrivateLink docs -
The
10.248.64.0/18CIDR belongs to the VPC in the PrivateLink/Edge account. The VPC endpoints use this CIDR. But the clients are not going to be in the edge account VPC. Instead they are going to be in the peered VPCs. So we are proposing allowing a wider CIDR range.Merge timing
Related issues (optional)