Updates to the Analytics.js (Javascript) Source #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this section of the doc ( lines 54-58) display incorrectly on the web page. The output:
analytics.identify('{{ user.id }\}', {
name: '{{ user.fullname }\}',
email: '{{ user.email }\}'
});
appears like this:
analytics.identify('\', {
name: '\',
email: '\'
});
After researching on stackoverflow, I believe these changes should fix the issue.
|
Hey there, this doesn't build. The actual change we need to make here is to add more escape characters as |
|
Hm, I'm going to have to troubleshoot this locally. It may be that we just replace the {{ entirely since different parts of the build are disagreeing with them. |
|
Okay, I figured out how to do this. Adding a {% raw %} and {% endraw %} tag just inside the code block so that this renders correctly. Whew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this section of the doc ( lines 54-58) display incorrectly on the web page. The output:
analytics.identify('{{ user.id }}', {
name: '{{ user.fullname }}',
email: '{{ user.email }}'
});
appears like this:
analytics.identify('', {
name: '',
email: ''
});
After researching on stackoverflow, I believe these changes should fix the issue.
Proposed changes
Moved the ignore characters as follows:
OLD
analytics.identify('{{ user.id }}', {
name: '{{ user.fullname }}',
email: '{{ user.email }}'
NEW
analytics.identify('{{ user.id }}', {
name: '{{ user.fullname }}',
email: '{{ user.email }}'
Related issues (optional)