Skip to content

add One Creation Source documentation #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

yanghcheung
Copy link
Contributor

Proposed changes

add One Creation documentation

Merge timing

ASAP once approved

Related issues (optional)

add One Creation documentation
@yanghcheung yanghcheung requested a review from a team as a code owner August 12, 2024 21:31
@yanghcheung yanghcheung requested a review from pwseg August 12, 2024 21:31
@pwseg pwseg requested a review from tcgilbert August 13, 2024 16:46
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the requested changes, please change the folder name to be the same as the integration slug:

  • onecreation --> one-creation

yanghcheung and others added 4 commits August 14, 2024 08:56
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
@yanghcheung yanghcheung requested a review from tcgilbert August 14, 2024 13:06
@pwseg pwseg added the new-integration Added a new source or destination label Aug 20, 2024
@pwseg pwseg changed the title add One Creation documentation add One Creation Source documentation Aug 20, 2024
pwseg
pwseg previously approved these changes Aug 20, 2024
@pwseg pwseg enabled auto-merge August 20, 2024 16:24
@pwseg pwseg disabled auto-merge August 20, 2024 16:24
@pwseg pwseg dismissed tcgilbert’s stale review August 20, 2024 16:25

They took care of this.

@pwseg pwseg merged commit d966425 into segmentio:develop Aug 20, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants