Update snowflake-setup.md #7076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IP allow list info to retl docs for snowflake
|
@charholt is there a reason why we need this specifically on the Snowflake RETL setup page? |
|
It really should be on all the set-up pages except BQ, since allow listing is a requirement for almost all the connections. I can update my PR! Do you want me to use the pre-built info or just add it to the docs as a note? |
|
@charholt is this note still necessary to have in our docs? It's been almost a year. Did all users not update their allowlists? |
stayseesong
approved these changes
Nov 4, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
RETL docs, are missing allowlist info. Added the pre-built IP allowlist info.
Merge timing