Skip to content

Conversation

accoilmj
Copy link
Contributor

@accoilmj accoilmj commented Oct 8, 2024

Proposed changes

  • I noticed some of the JavaScript tags weren't properly closed so I've fixed these here.
  • Added a direct link to the catalog from our doc.

Merge timing

Once approved, please.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit e22365d
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6705ba2d7a39430008e5e59e
😎 Deploy Preview https://deploy-preview-7122--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@accoilmj accoilmj marked this pull request as ready for review October 8, 2024 03:50
@accoilmj accoilmj requested a review from a team as a code owner October 8, 2024 03:50
@accoilmj accoilmj requested a review from forstisabella October 8, 2024 03:50
@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label Oct 8, 2024
@accoilmj accoilmj force-pushed the AAD-428-fix-javascript-blocks branch from 9328544 to ec06b69 Compare October 8, 2024 23:00
@accoilmj accoilmj force-pushed the AAD-428-fix-javascript-blocks branch from ec06b69 to e22365d Compare October 8, 2024 23:03
@accoilmj
Copy link
Contributor Author

accoilmj commented Oct 9, 2024

I notice there were some conflicts introduced when the folder got moved and docs made public separately so I've rebased to fix those.

@accoilmj accoilmj changed the title Accoil updates & beta Accoil updates Oct 10, 2024
@forstisabella forstisabella merged commit 6f4ea63 into segmentio:develop Oct 10, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants