Skip to content

Update custom-proxy.md #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update custom-proxy.md #7263

merged 2 commits into from
Nov 26, 2024

Conversation

jfoskin
Copy link
Contributor

@jfoskin jfoskin commented Nov 25, 2024

Proposed changes

Info note about when events are being sent through proxy

Merge timing

Related issues (optional)

@jfoskin jfoskin added the KCS label Nov 25, 2024
@jfoskin jfoskin marked this pull request as ready for review November 25, 2024 19:48
@jfoskin jfoskin requested a review from a team as a code owner November 25, 2024 19:48
@jfoskin jfoskin requested a review from stayseesong November 25, 2024 19:48
Comment on lines 171 to 172
> info ""
> Events travel through the proxy before reaching tracking api.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> info ""
> Events travel through the proxy before reaching tracking api.

@stayseesong stayseesong merged commit 23651e3 into develop Nov 26, 2024
5 checks passed
@stayseesong stayseesong deleted the jfoskin-patch-13 branch November 26, 2024 17:29
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants