Skip to content

Reddit Conversions API Destination Documentation #7295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

akhsueh
Copy link
Contributor

@akhsueh akhsueh commented Dec 5, 2024

Proposed changes

This is the documentation we've created for the Reddit Conversions API destination (https://github.com/segmentio/action-destinations/tree/reddit_capi/packages/destination-actions/src/destinations/reddit-conversions-api)

Let us know if everything looks OK or if there is any feedback on it. Thank you.

Merge timing

ASAP once approved

@akhsueh akhsueh requested a review from a team as a code owner December 5, 2024 18:30
@akhsueh akhsueh requested a review from pwseg December 5, 2024 18:30
@pwseg pwseg requested a review from tcgilbert December 5, 2024 18:39
Comment on lines 1 to 3
---
title: Reddit Conversions API (Actions) Destination
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
title: Reddit Conversions API (Actions) Destination
---
---
title: Reddit Conversions API (Actions) Destination
id: 66cc766ef4b1c152177239a0
---

@tcgilbert
Copy link
Contributor

@akhsueh I noticed that you titled the destination Reddit Conversions API (Actions)

Right now, the actual name for your integration on our backend is Reddit Conversions Api, so this is how it would appear in app. Would you like to update this? If so what would you prefer?

  • options
    • Reddit Conversions API (Actions)
    • Reddit Conversions API

@akhsueh
Copy link
Contributor Author

akhsueh commented Dec 6, 2024

Thanks @tcgilbert , "Reddit Conversions API" is preferred so I just made the update to that. Added the ID in as well.

tcgilbert
tcgilbert previously approved these changes Dec 10, 2024
@pwseg pwseg changed the title Reddit Conversions API Doc Reddit Conversions API Destination Documentation Dec 12, 2024
@pwseg pwseg added the new-integration Added a new source or destination label Dec 12, 2024
@pwseg pwseg merged commit 2585a6a into segmentio:develop Dec 12, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants