-
Notifications
You must be signed in to change notification settings - Fork 382
Rewrite docs for Functions #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Edited this, because a single word is too short. Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Hey @vadimdemedes in the interests of not making this branch's commit chain any longer, do you want to just push a commit with all your code changes? If they don't need a second reviewer, I think this is fine. |
Why not? You can combine multiple suggestions into one commit by using "Add suggestion to batch" button. |
TIL about batching, thanks! @vadimdemedes but do these code changes need a dev review? |
@chriso Could you take a look at code suggestions above? |
getTime() returns milliseconds, not seconds.
@andy it looks like we have a few outstanding code-format edits from Vadim. I'll review the branch conflicts today. |
Okay, just ready for any outstanding suggestions from Vadim and any new updates! |
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
Co-authored-by: Vadim Demedes <vdemedes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There needs to be some work down for updating visuals + adding in new nicer visuals. Waiting to hear back from Design team on resources here.
For anyone from @segmentio/functions-team reviewing this PR, would love eyes overall but in particular:
[ ] Any content suggestions for the Functions Overview page. I’ve been writing so much about Functions lately, burning out a little bit :lol: The Personas Overview page is a great benchmark or reference for inspo!
[ ] As you’ve all been on-call and answered questions multiple times, is there anything missing from the documentation shared here?
[ ] List of dependencies are complete and 100% correct in terms of versions. Under Source Functions, can I get some help filling out descriptions for the three other dependencies - form-data v2.4.0, oauth v0.9.15 and xml v1.0.1 🙏 I didn’t know we supported the XML one?!
[ ] Overall accuracy of our documentation, I’ve tried my best to verify aspects of these docs but would appreciate everyone’s review here as we head to GA!