Skip to content

[STRATCONN-319] Revamp Adobe Analytics docs #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Jul 24, 2020
Merged

[STRATCONN-319] Revamp Adobe Analytics docs #990

merged 60 commits into from
Jul 24, 2020

Conversation

briemcnally
Copy link
Contributor

@briemcnally briemcnally commented Jul 7, 2020 •
edited
Loading

Proposed changes

  • Adobe docs revamped as part of my HW project
  • This revamp parses the data into more granular sections. Particularly: New Simple AA Home Page Implementing Segment for Adobe Analytics, Setting up Adobe Analytics for Mobile, Setting up Adobe Analytics Heartbeat, and Adobe Analytics Best Practices
  • Updates all images to reference V2 settings UI (including new ship to improved settings UI features shipped 7/23)
  • Most info and research pulled from my Adobe Internal Home doc that was shared internally during Q2: https://paper.dropbox.com/doc/WIP-Adobe-Analytics-Home-eIGJbvfBe3d8FeOkqKV19

Merge timing

  • Will plan to merge once approved

Related issues (optional)

@briemcnally briemcnally requested a review from sanscontext July 7, 2020 00:37
sanscontext and others added 19 commits July 6, 2020 17:49
info formatting :)
59c1aaa
Update getting started
838a8fb
Add identity resolution and setup/settings to side nav
6d794f6
Refactor using side nav tabs
b0b7179
Merge branch 'brie/hw-aa-docs' of ssh://github.com/segmentio/segment-…
022e65d 
…docs into brie/hw-aa-docs
Update images for AA Settings V2
681ba28
Change side nav title for implementing AA
704d12e
Update Overview & Success Events
918cda6
Rename images using -
4746b1f
Add eVar section
7b8af1f
Update merchandising events
8235e3b
Update props
3f58b4f
Update list variablese
2694357
Add external docs for list vars
06541b4
Add hierarchy varrs
2315870
Add segment dest specific options
59cabb4
Update hyperlinks in table of contents
f131c87
Remove provide feedback from images
33dc036
Add more edits to implementation/settings page
4883102
@briemcnally
Copy link
Contributor Author

Associated PR to be merged on App to update AA V2 settings to ensure parity with documentation: https://github.com/segmentio/app/pull/10054

@briemcnally briemcnally changed the title [WIP] Hack Week Revamp Adobe Heartbeat docs [WIP] Hack Week Revamp Adobe Analytics docs Jul 9, 2020
@briemcnally
Copy link
Contributor Author

Lucid Chart Link: https://app.lucidchart.com/documents/edit/f5c37304-0a48-412c-9221-97d52bfdeba2/0_0?beaconFlowId=D2FD77201B5F6B06

@briemcnally briemcnally requested a review from gpsamson July 9, 2020 20:33
@briemcnally briemcnally marked this pull request as ready for review July 24, 2020 17:24
@briemcnally
Copy link
Contributor Author

@sanscontext left some comments in b/c I left response comments back to you. Happy to schedule a quick 15-30 to discuss remaining 2-3 comments today or Monday pending your schedule. I will plan to remove the comments once you have had a chance to review. Looking at all merge conflicts now. Thanks again for all your help and guidance 😄

sanscontext
sanscontext reviewed Jul 24, 2020
View reviewed changes
@briemcnally briemcnally changed the title [WIP] Hack Week Revamp Adobe Analytics docs [STRATCONN-319] Revamp Adobe Analytics docs Jul 24, 2020
sanscontext
sanscontext approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@briemcnally briemcnally merged commit 868ef2d into master Jul 24, 2020
@sanscontext sanscontext deleted the brie/hw-aa-docs branch July 24, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsamson gpsamson Awaiting requested review from gpsamson

@benhorowitz benhorowitz Awaiting requested review from benhorowitz

@danielstjules danielstjules Awaiting requested review from danielstjules

@n2parko n2parko Awaiting requested review from n2parko

1 more reviewer

@sanscontext sanscontext sanscontext approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briemcnally @sanscontext