Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip is offset, out of the parent div #649

Closed
sorryjack opened this issue Nov 3, 2016 · 5 comments · May be fixed by #953
Closed

tooltip is offset, out of the parent div #649

sorryjack opened this issue Nov 3, 2016 · 5 comments · May be fixed by #953

Comments

@sorryjack
Copy link

thanks for making this awesome slider.

I implemented the tooltip_split : true

the minimum one, the left is offset the div, so does the max one. please see the screenshot.
screenshot-local jack-2016-11-03-12-02-56
is it possible to make the tooltip auto positioned when the reach their edge wether min or max to keep the tooltip visible?

thanks.

@seiyria
Copy link
Owner

seiyria commented Nov 3, 2016

I don't understand. The tool tips are centered on top of the handles, but
I'm not sure what you're getting at.

On Thu, Nov 3, 2016, 00:08 sorryjack notifications@github.com wrote:

thanks for making this awesome slider.

I implemented the tooltip_split : true

the minimum one, the left is offset the div, so does the max one. please
see the screenshot.
[image: screenshot-local jack-2016-11-03-12-02-56]
https://cloud.githubusercontent.com/assets/6811578/19956353/194818ac-a1be-11e6-8da7-ba1a477f6135.png
is it possible to make the tooltip auto positioned when the reach their
edge wether min or max to keep the tooltip visible?

thanks.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#649, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAum2RaNYgWX1cbNKohBO9VJ7jN_94naks5q6WxogaJpZM4KoAi0
.

@sorryjack
Copy link
Author

cropped
please consider as its on mobile device or full width view. the tooltip is only half visible.

Thanks.

@seiyria
Copy link
Owner

seiyria commented Nov 4, 2016

That happens with tool tips. Add some padding on the left and right until
it fits the way you want.

On Thu, Nov 3, 2016, 22:48 sorryjack notifications@github.com wrote:

[image: cropped]
https://cloud.githubusercontent.com/assets/6811578/19993924/cc41a2b2-a27b-11e6-9728-118433c6d7a2.png
please consider as its on mobile device or full width view. the tooltip is
only half visible.

Thanks.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#649 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAum2Ubyz7y_LJgsdBbPxFfp-4DcGfKeks5q6qr3gaJpZM4KoAi0
.

@seiyria seiyria closed this as completed Nov 4, 2016
@robsdedude
Copy link

robsdedude commented Apr 18, 2017

In fact, bootstrap is capable of keeping tooltips in bound.

Appends the tooltip to a specific element. Example: container: 'body'. This option is particularly useful in that it allows you to position the tooltip in the flow of the document near the triggering element - which will prevent the tooltip from floating away from the triggering element during a window resize.

From http://getbootstrap.com/javascript/#tooltips

And I'd love to see such a feature for this library as well.

@seiyria
Copy link
Owner

seiyria commented Apr 18, 2017

Append to body would not solve this issue, it prevents it from getting clipped when it would otherwise overflow the container.

That said, if a fix is desired, then please send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants