allow range slider to snap bounds. #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovolution
requested changes
Nov 25, 2018
There was a problem hiding this comment.
@viceice could you please write some unit tests to validate that this fix indeed resolves the bug in question? please reference our other unit tests as a guide. thanks!
rovolution
reviewed
Nov 25, 2018
|
Added a test case. |
rovolution
approved these changes
Nov 28, 2018
jespirit
added a commit
to heidarsaleh/bootstrap-slider
that referenced
this pull request
Dec 16, 2018
Merged changes from: seiyria#873
jespirit
added a commit
to heidarsaleh/bootstrap-slider
that referenced
this pull request
Dec 21, 2018
Merged changes from: seiyria#873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #392
Pull Requests
Please accompany all pull requests with the following (where appropriate):
grunt testin your Terminal within the bootstrap-slider repository directory