CI: update GolangCI-Lint settings (#104)

* CI: update GolangCI-Lint settings

Use .golangci.yml for GolangCI-Lint configuration and remove Gocritic
since it can be called from the GolangCI-Lint.

* ResellV2: fix spelling in Quotas package

Use "length" in the projectQuotasSlice comment.

.golangci.yml

@@ -0,0 +1,8 @@
+linters:
+  fast: false
+  enable-all: true
+  disable:
+    - dupl
+    - gochecknoglobals
+    - gosec
+    - lll

.travis.yml

@@ -3,8 +3,7 @@ language: go
 install:
   - go get github.com/mattn/goveralls
   - go get github.com/wadey/gocovmerge
-  - go get github.com/go-critic/go-critic/...
-  - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOPATH/bin v1.11.2
+  - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOPATH/bin v1.12.3
 go:
   - "1.11"
 script:

GNUmakefile

@@ -1,14 +1,11 @@
 default: tests
 
-tests: golangci-lint critic unittest
+tests: golangci-lint unittest
 
 unittest:
 	@sh -c "'$(CURDIR)/scripts/gotest.sh'"
 
 golangci-lint:
 	@sh -c "'$(CURDIR)/scripts/golangci_lint_check.sh'"
 
-critic:
-	@sh -c "'$(CURDIR)/scripts/gocritic_check.sh'"
-
-.PHONY: tests unittest golangci-lint critic
+.PHONY: tests unittest golangci-lint

scripts/golangci_lint_check.sh

@@ -1,20 +1,7 @@
 #!/usr/bin/env bash
 
 echo "==> Running golangci-lint..."
-golangci-lint run \
-    --enable golint \
-    --enable interfacer \
-    --enable unconvert \
-    --enable goconst \
-    --enable gocyclo \
-    --enable gofmt \
-    --enable goimports \
-    --enable maligned \
-    --enable depguard \
-    --enable unparam \
-    --enable nakedret \
-    --enable prealloc \
-    ./...
+golangci-lint run ./...
 if [ $? -eq 1 ]; then
     echo ""
     echo "Golangci-lint found suspicious constructs. Please check the reported"; \

selvpcclient/resell/v2/quotas/schemas.go

@@ -141,7 +141,7 @@ func (result *ProjectsQuotas) UnmarshalJSON(b []byte) error {
 	if len(s.ProjectsQuotas) != 0 {
 		// Convert projects quota maps to the slice of ProjectQuota types.
 		// Here we're allocating memory in advance for both of project and resource quotas
-		// because we already know the lenght of each slices from the JSON bytearray.
+		// because we already know the length of each slices from the JSON bytearray.
 		projectQuotasSlice := make([]*ProjectQuota, len(s.ProjectsQuotas))
 		i := 0
 		for projectName, projectQuotas := range s.ProjectsQuotas {