Skip to content

Expand "--firefox-pref=KEY:VALUE" to support URLs as VALUEs (which contain ":") #2387

@mdmintz

Description

@mdmintz

Expand --firefox-pref="KEY:VALUE" to support URLs as VALUEs (which contain ":")


Currently, --firefox-arg=FIREFOX_ARG and --firefox-pref=FIREFOX_PREF work like this:

  --firefox-arg=FIREFOX_ARG,
        Add a Firefox argument for Firefox browser runs.
        Format: A comma-separated list of Firefox args.
        If an arg doesn't start with "--", that will be
        added to the beginning of the arg automatically.
  --firefox-pref=FIREFOX_PREF,
        Set a Firefox preference:value combination.
        Format: A comma-separated list of pref:value items.
        Example usage:
            --firefox-pref="browser.formfill.enable:True"
            --firefox-pref="pdfjs.disabled:False"
            --firefox-pref="abc.def.xyz:42,hello.world:text"
        Boolean and integer values to the right of the ":"
        will be automatically converted into proper format.
        If there's no ":" in the string, then True is used.

Since FIREFOX_PREF is in KEY:VALUE format (which uses ":" for separation), the code must be updated to allow for a second ":" (which would allow URLs as VALUEs). Can still have ","-separated entries for multiple KEY:VALUE sets.

Example usage when allowing for URLs as VALUEs:
    --firefox-pref="something.url:https://github.com"
    --firefox-pref="abc.def.xyz:42,something.url:https://github.com"

Note that the above shows the pytest command-line option format.
(For SB() and Driver() formats, use firefox_pref="KEY:VALUE".)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions