-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Description
Switch the AngularJS waits to be disabled by default
Currently, there's a switch that makes SeleniumBase wait for AngularJS to finish loading after every single page load (and other actions). It's been enabled since early 2018: 9f11c76.
It doesn't make sense to keep this switch on anymore by default, given the declining popularity of AngularJS relative to other front-end frameworks. (Even if there's no AngularJS on a website, it adds a very tiny wait due to running some JavaScript to check that AngularJS finished loading.) And it seems that some websites make the script timeout, forcing a one-second delay in those cases each time the code block is called. (This should probably be reduced.)
Not only that, but it was just for AngularJS (not the newer Angular).
Due to the expected speed boost after changing default settings, I may want to add a tiny wait in its place for UC Mode scripts (otherwise they may appear to run at super-human speeds, making websites detect Selenium as bots more easily). I'll experiment, and see what works best.