Skip to content

Perform Windows and Edge optimizations #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Conversation

mdmintz
Copy link
Member

@mdmintz mdmintz commented Mar 18, 2022

Perform Windows and Edge optimizations

  • Check for service process before driver.quit() on Windows
    -- (This prevents a hanging process during cleanup if a driver was already quit. Sometimes people forget that SeleniumBase already quits drivers automatically at the end of tests, so if they manually try to quit a driver during a test, then during the cleanup phase there would be a hanging process on Windows when SeleniumBase tries to quit the driver again. Now, a check is performed to find out if drivers have already been quit.)
    -- (In the case of tests that spin up multiple drivers using self.get_new_driver(), in SeleniumBase 2.4.22, a new method was added: self.quit_extra_driver(), which quits extra drivers safely, and then removes those drivers from the list of drivers to be quit automatically at the end of tests.)
  • Update default EdgeDriver version if can't detect latest

@mdmintz mdmintz merged commit 8a35993 into master Mar 18, 2022
@mdmintz mdmintz deleted the windows-optimizations branch March 18, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant