Skip to content

Fix issue with proxy server auth in chrome headless mode #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Fix issue with proxy server auth in chrome headless mode #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7be87df
Workaround for using a proxy server with auth in Chrome headless mode
mdmintz Oct 30, 2018
3a3bad9
Change default screen resolutions for browser windows
mdmintz Oct 30, 2018
77dde1e
Version 1.16.17
mdmintz Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion seleniumbase/core/browser_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,13 @@ def get_local_driver(
downloads_path, proxy_string, proxy_auth,
proxy_user, proxy_pass)
if headless:
chrome_options.add_argument("--headless")
# Headless Chrome doesn't support extensions, which are
# required when using a proxy server that has authentication.
# Instead, base_case.py will use PyVirtualDisplay when not
# using Chrome's built-in headless mode. See link for details:
# https://bugs.chromium.org/p/chromium/issues/detail?id=706008
if not proxy_auth:
chrome_options.add_argument("--headless")
chrome_options.add_argument("--disable-gpu")
chrome_options.add_argument("--no-sandbox")
if LOCAL_CHROMEDRIVER and os.path.exists(LOCAL_CHROMEDRIVER):
Expand Down
6 changes: 3 additions & 3 deletions seleniumbase/fixtures/base_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,7 +2234,7 @@ def get_new_driver(self, browser=None, headless=None,
if self.headless:
# Make sure the invisible browser window is big enough
try:
self.set_window_size(1920, 1200)
self.set_window_size(1440, 1080)
self.wait_for_ready_state_complete()
except Exception:
# This shouldn't fail, but in case it does,
Expand All @@ -2247,7 +2247,7 @@ def get_new_driver(self, browser=None, headless=None,
if settings.START_CHROME_IN_FULL_SCREEN_MODE:
self.driver.maximize_window()
else:
self.driver.set_window_size(1250, 800)
self.driver.set_window_size(1250, 840)
self.wait_for_ready_state_complete()
except Exception:
pass # Keep existing browser resolution
Expand Down Expand Up @@ -2654,7 +2654,7 @@ def setUp(self):
if self.headless:
try:
from pyvirtualdisplay import Display
self.display = Display(visible=0, size=(1920, 1200))
self.display = Display(visible=0, size=(1440, 1080))
self.display.start()
self.headless_active = True
except Exception:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

setup(
name='seleniumbase',
version='1.16.16',
version='1.16.17',
description='All-In-One Test Automation Framework',
long_description=long_description,
long_description_content_type='text/markdown',
Expand Down