capabilities_parser parse ast and json #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piotrkochan
commented
Dec 30, 2019
piotrkochan
commented
- parse json - .json files
- parse ast - raw .py dist
- parse .py as normal if other ways failed
mdmintz
reviewed
Dec 30, 2019
|
|
||
|
|
||
| def get_desired_capabilities(cap_file): | ||
| f = open(cap_file, 'r') |
There was a problem hiding this comment.
You have to verify the file type before doing any kind of file parsing.
|
@piotrkochan I added the review. You should verify the file type before parsing the desired capabilities file. Thanks for contributing this pull request! |
mdmintz
reviewed
Dec 30, 2019
Comment on lines
+191
to
+192
| else: | ||
| raise Exception("\n\n`%s` is not a Python or JSON file!\n" % cap_file) |
There was a problem hiding this comment.
This part should happen before f = open(cap_file, 'r') if the file type is invalid.
|
@piotrkochan Merged! It'll be part of the next release. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.