Skip to content

Conversation

rjyounes
Copy link
Collaborator

@rjyounes rjyounes commented Nov 9, 2023

Fixes #1006

Copy link
Contributor

@Jamie-SA Jamie-SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not real thrilled with this change. This means that the hook will not automatically be updated when changed in the git repo.

However, there is already issue #891 about having to deal with this for the main hook, so it could be dealt with in the same way.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Nov 9, 2023

This means that the hook will not automatically be updated when changed in the git repo.

If the main pre-commit changes in the repo you have to rerun /tools/setup.cmd. This handles changes to the serializer pre-commit the same way, unless I'm missing something.

@Jamie-SA
Copy link
Contributor

Jamie-SA commented Nov 9, 2023

Yes, but see the issue I referenced: #891
You don't currently have to run setup.cmd if the serialize/pre-commit changes, but you will after this change.

@rjyounes
Copy link
Collaborator Author

I see. I see you added a comment to that effect on #891. It seems to me to be in principle the same issue.

@rjyounes rjyounes merged commit 91bf4b3 into develop Nov 16, 2023
@rjyounes rjyounes deleted the issue-1006-pre-commit branch November 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix pre-commit permissions problem
2 participants