Skip to content

Fix serializer pre-commit permissions problem #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix serializer pre-commit permissions problem #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e8b55
Fix serializer pre-commit permissions problem
rjyounes Nov 9, 2023
7b57a96
Add release note
rjyounes Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/release_notes/1007-pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Patch Updates

- Fixed serializer pre-commit hook permissions problem on MacOS.
5 changes: 2 additions & 3 deletions tools/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ base_dir=$(git rev-parse --show-toplevel)
# Run the serializer
set -x

# Ensure that the serializer pre-commit is executable
chmod +x "${base_dir}/tools/serializer/pre-commit"
"$base_dir/tools/serializer/pre-commit"
"${base_dir}/.git/hooks/pre-commit-serializer"

rc=$?
set +x

Expand Down
5 changes: 5 additions & 0 deletions tools/setup.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ cp "${base_dir}/tools/pre-commit" "${base_dir}/.git/hooks/"
# Make pre-commit hook executable. Needed at least on Mac, where the copied file is non-executable unless there's an existing executable file in the hooks directory, regardless of the status of the original file.
chmod +x "${base_dir}/.git/hooks/pre-commit"

# Copy serializer pre-commit to hooks directory. Needed for Mac, where the permissions on the file keep changing (after it executes?) and therefore GitHub detects.
cp "${base_dir}/tools/serializer/pre-commit" "${base_dir}/.git/hooks/pre-commit-serializer"
# Ensure that the serializer pre-commit hook is executable.
chmod +x "${base_dir}/.git/hooks/pre-commit-serializer"

# Exit linux shell
exit

Expand Down