Skip to content

fix geo route and remove geo segment #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 2, 2025
Merged

fix geo route and remove geo segment #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba9c6b7
remove GeoSegment class
Jan 24, 2025
13a065f
update GeoRoute class equivalence to say GeoPoints are members (not p…
Jan 24, 2025
d2a55ac
added release note
Jan 27, 2025
3e72201
fixed release note
Jan 31, 2025
3e3c5fc
updated to deprecate GeoSegment and refer to issue #1181 in gist 14 t…
Feb 1, 2025
038f9ba
Update ontologies/gistCore.ttl
rjyounes Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/release_notes/issue1165-remove-geosegment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
### Minor Updates

- Deprecate `gist:GeoSegment`. Issue [#1165](https://github.com/semanticarts/gist/issues/1165).

### Patch Updates

- Correct errors in property restriction on `gist:GeoRoute`. Issue [#1165](https://github.com/semanticarts/gist/issues/1165).
9 changes: 5 additions & 4 deletions ontologies/gistCore.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,20 +770,20 @@ gist:GeoRoute
[
a owl:Restriction ;
owl:onProperty [
owl:inverseOf gist:isDirectPartOf ;
owl:inverseOf gist:isMemberOf ;
] ;
owl:someValuesFrom gist:GeoSegment ;
owl:someValuesFrom gist:GeoPoint ;
]
) ;
] ;
skos:definition "An ordered set of GeoPoints that defines a path from starting point to ending point."^^xsd:string ;
skos:definition "An ordered set of GeoPoints that defines a path from a starting point to an ending point."^^xsd:string ;
skos:prefLabel "Geo Route"^^xsd:string ;
skos:scopeNote "Each pair of consecutive GeoPoints in a GeoRoute is a GeoSegment."^^xsd:string ;
.

gist:GeoSegment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deprecated, with an editorial note and addition of a new issue for 14.0.0. See section "How to Deprecate" in Deprecation and Deletion Policy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Issue #1181 for gist 14 will remove GeoSegment. I deprecated GeoSegment and added a note referring to issue #1181 to remove GeoSegment in gist 14. Also corrected the class equivalence statement for GeoRoute so it uses isMemberOf and GeoPoint.

I think this is ready now. Thanks for the help.

a owl:Class ;
rdfs:subClassOf gist:Place ;
owl:deprecated "true"^^xsd:boolean ;
owl:equivalentClass [
a owl:Class ;
owl:intersectionOf (
Expand All @@ -802,6 +802,7 @@ gist:GeoSegment
) ;
] ;
skos:definition "A single portion of a GeoRoute consisting of a pair of consecutive GeoPoints which belong to it."^^xsd:string ;
skos:editorialNote "See guidance on removing this term in the next major release at #1182."^^xsd:string ;
skos:prefLabel "Geo Segment"^^xsd:string ;
skos:scopeNote "A GeoSegment is also a GeoRoute (a short one)."^^xsd:string ;
.
Expand Down