Skip to content

Conversation

dbsemantic
Copy link
Contributor

No description provided.

@dbsemantic dbsemantic requested a review from rjyounes July 9, 2025 23:17
@dbsemantic dbsemantic linked an issue Jul 9, 2025 that may be closed by this pull request
@dbsemantic
Copy link
Contributor Author

dbsemantic commented Jul 10, 2025

@rjyounes Question about the release note: I mention deleting isAssignedBy, but since that property was added between last release and the next would it make more sense to just modify the release note which added it? Or do we prefer not to rewrite history in this case?

Update: after reading through the contributing documentation I've come to the conclusion that the release notes should be combined. Let me know if I'm misunderstanding the instructions.

Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why there are other diffs here that have to do with the serializer reordering of statements. Either the serializer was not run in the previous release or it hasn't been run here.

dbsemantic and others added 2 commits August 14, 2025 08:18
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@dbsemantic
Copy link
Contributor Author

I don't know why there are other diffs here that have to do with the serializer reordering of statements. Either the serializer was not run in the previous release or it hasn't been run here.

Yeah I thought that was strange as well, but I definitely ran the serializer the first time, and when I ran it again when merging in develop it produced similar results. Are there any settings or configurations for the serializer that I might have missed beyond running serialize.sh?

@dbsemantic dbsemantic requested a review from rjyounes August 14, 2025 15:26
@rjyounes rjyounes moved this to In Review in gist Version 14.0.0 Aug 21, 2025
@rjyounes rjyounes assigned rjyounes and dbsemantic and unassigned rjyounes Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Drop isAssignedBy and use hasGiver for Assignments?
2 participants