-
Notifications
You must be signed in to change notification settings - Fork 22
Delete isAssignedBy and references #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Delete isAssignedBy and references #1243
Conversation
@rjyounes Question about the release note: I mention deleting isAssignedBy, but since that property was added between last release and the next would it make more sense to just modify the release note which added it? Or do we prefer not to rewrite history in this case? Update: after reading through the contributing documentation I've come to the conclusion that the release notes should be combined. Let me know if I'm misunderstanding the instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why there are other diffs here that have to do with the serializer reordering of statements. Either the serializer was not run in the previous release or it hasn't been run here.
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Yeah I thought that was strange as well, but I definitely ran the serializer the first time, and when I ran it again when merging in develop it produced similar results. Are there any settings or configurations for the serializer that I might have missed beyond running serialize.sh? |
No description provided.