Tasks and templates. Fixes #590, fixes #408. #691

uscholdm · 2022-06-26T14:31:24Z

No description provided.

gistCore.ttl

Jamie-SA · 2022-09-08T14:52:01Z

gistCore.ttl

 		) ;
 	] ;
-	skos:definition "A task planned to occur.  When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:altLabel "Scheduled Task Execution"^^xsd:string ;


This looks identical to the prefLabel. Is it needed?

Suggested change

skos:altLabel "Scheduled Task Execution"^^xsd:string ;

rjyounes

In addition to my inline comments, this needs a release note.

rjyounes · 2022-09-25T20:33:39Z

gistCore.ttl

-	skos:prefLabel "Project"^^xsd:string ;
+	skos:definition "A project execution is a task execution (usually a longer duration task) made up of other task executions."^^xsd:string ;
+	skos:prefLabel "Project Execution"^^xsd:string ;
+	skos:scopeNote "Note that this definition differs from the ordinary sense of 'project', which is something to do. Here, project execution means the event of doing the work."^^xsd:string ;


I don't think the scopeNote is relevant any longer. It was used when the name of the class was Project.

rjyounes · 2022-09-25T20:34:16Z

gistCore.ttl

-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:definition "A task execution that has already been planned to occur at a given time. When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
+	skos:prefLabel "Scheduled Task Execution"^^xsd:string ;
+	skos:scopeNote "Note that this differs from the ordinary sense of 'task' which is something to do. Here task refers to the event of doing the work."^^xsd:string ;


I don't think the scopeNote is relevant any longer. It was used when the name of the class was ScheduledTask.

rjyounes · 2022-09-25T20:34:40Z

gistCore.ttl

-	skos:prefLabel "Task"^^xsd:string ;
-	skos:scopeNote "Note that this differs from the ordinary sense of 'task,' which is not an event (e.g., 'A piece of work to be done or undertaken.')."^^xsd:string ;
+	skos:prefLabel "Task Execution"^^xsd:string ;
+	skos:scopeNote "Note that, task execution refers to the event of doing the work which differs from the ordinary sense of 'Task,' as 'something to to'.  For the latter, consider using the class: TaskTemplate."^^xsd:string ;


I don't think the scopeNote is relevant any longer. It was used when the name of the class was Task. In any case, the comma after "Note that" should be removed.

rjyounes · 2022-09-25T20:35:12Z

gistCore.ttl

@@ -2310,8 +2312,9 @@ gist:TaskTemplate
 			]
 		) ;
 	] ;
-	skos:definition "An outline of a task of a particular type, that will, when instantiated, generate an actual (unscheduled) task."^^xsd:string ;
+	skos:definition "An outline of a task of a particular type which is the basis for executing such tasks."^^xsd:string ;


Need comma before "which."

rjyounes · 2022-09-25T20:35:54Z

gistCore.ttl

+		"A die in manufacturing that is used to make stamped parts. "^^xsd:string ,
+		"A form. A filled-in form has the structure of the form with data entered into some or all of the fields."^^xsd:string ,
+		"Cookie cutters are templates for cookies."^^xsd:string ,
+		"God"^^xsd:string


WHAT?? I don't get it. Plus, is this going to be controversial/offensive?

It is said that God made us in his own image, so it is a pretty good fit to the definition. I only put it there to see if anyone is paying attention :-)

gistCore.ttl

rjyounes · 2022-09-25T20:43:26Z

gistCore.ttl

 		) ;
 	] ;
-	skos:definition "A task planned to occur.  When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:definition "A task execution that has already been planned to occur at a given time. When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;


In the definition, I would prefer the more idiomatic "the execution of a task..." Your choice ultimately.

uscholdm

I accidentally started a review when I only meant to respond to comments.

uscholdm · 2022-09-28T18:39:33Z

gistCore.ttl

-	skos:prefLabel "Project"^^xsd:string ;
+	skos:definition "A project execution is a task execution (usually a longer duration task) made up of other task executions."^^xsd:string ;
+	skos:prefLabel "Project Execution"^^xsd:string ;
+	skos:scopeNote "Note that this definition differs from the ordinary sense of 'project', which is something to do. Here, project execution means the event of doing the work."^^xsd:string ;


uscholdm · 2022-09-28T18:40:23Z

gistCore.ttl

 		) ;
 	] ;
-	skos:definition "A task planned to occur.  When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:definition "A task execution that has already been planned to occur at a given time. When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;


uscholdm · 2022-09-28T18:43:43Z

gistCore.ttl

-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:definition "A task execution that has already been planned to occur at a given time. When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
+	skos:prefLabel "Scheduled Task Execution"^^xsd:string ;
+	skos:scopeNote "Note that this differs from the ordinary sense of 'task' which is something to do. Here task refers to the event of doing the work."^^xsd:string ;


uscholdm · 2022-09-28T18:44:33Z

gistCore.ttl

-	skos:prefLabel "Task"^^xsd:string ;
-	skos:scopeNote "Note that this differs from the ordinary sense of 'task,' which is not an event (e.g., 'A piece of work to be done or undertaken.')."^^xsd:string ;
+	skos:prefLabel "Task Execution"^^xsd:string ;
+	skos:scopeNote "Note that, task execution refers to the event of doing the work which differs from the ordinary sense of 'Task,' as 'something to to'.  For the latter, consider using the class: TaskTemplate."^^xsd:string ;


uscholdm · 2022-09-28T18:47:52Z

gistCore.ttl

+		"A die in manufacturing that is used to make stamped parts. "^^xsd:string ,
+		"A form. A filled-in form has the structure of the form with data entered into some or all of the fields."^^xsd:string ,
+		"Cookie cutters are templates for cookies."^^xsd:string ,
+		"God"^^xsd:string


It is said that God made us in his own image, so it is a pretty good fit to the definition. I only put it there to see if anyone is paying attention :-)

gistCore.ttl

rjyounes · 2022-09-29T16:53:14Z

@rjyounes Make sure #408 is also addressed in this PR.

uscholdm · 2022-09-30T00:58:14Z

@rjyounes Make sure #408 is also addressed in this PR.

I did add words about made in the image, per #408. I don't know what more needs to be done. There is no DECISION specifying what is to be done.

rjyounes

In addition to one remaining inline comment, you need to add a release note.

rjyounes · 2022-10-01T20:26:25Z

gistCore.ttl

 		) ;
 	] ;
-	skos:definition "A task planned to occur.  When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;
-	skos:prefLabel "Scheduled Task"^^xsd:string ;
+	skos:definition "The execution of a task that has already been planned to occur at a given time. When it was scheduled, it would have been in the future, but now might be in the past."^^xsd:string ;


I find "already" odd here, and I also think "was" works better than "has been."

rjyounes

Everything looks great except for one piddly change to the release notes.

You have conflicts with the develop branch that you will need to resolve. Probably the release notes again. Also make sure that gistDeprecated gets merged properly: in addition to the duration instances from your previous PR, gist:Group should also be in there.

rjyounes · 2022-10-05T16:38:18Z

docs/ReleaseNotes.md

+- `gist:domainIncludes gist:Text` added to `gist:uniqueText`
+- Updated annotations for `gist:Template` [#408](https://github.com/semanticarts/gist/issues/408).
+- Changes to Tasks. Issue [#590](https://github.com/semanticarts/gist/issues/590).
+  - Renamed Task, ScheduledTask and Project to TaskExecution, ScheduledTaskExecution and ProjectExecution, respectively.


Could you put backticks around the class names?

Update annotations for Template (Issue #408)

…precated file.

rjyounes · 2022-10-05T19:18:00Z

Everything looks good.

uscholdm requested a review from rjyounes June 26, 2022 14:31

rjyounes requested changes Jun 26, 2022

View reviewed changes

gistCore.ttl Outdated Show resolved Hide resolved

gistCore.ttl Outdated Show resolved Hide resolved

gistCore.ttl Show resolved Hide resolved

gistCore.ttl Show resolved Hide resolved

uscholdm requested a review from rjyounes June 27, 2022 00:39

rjyounes changed the title ~~Issue 590 tasks and templates~~ Tasks and templates. Fixes #590. Jul 28, 2022

uscholdm assigned rjyounes and unassigned rjyounes Aug 25, 2022

uscholdm requested review from rjyounes and removed request for rjyounes August 25, 2022 22:38

Jamie-SA reviewed Sep 8, 2022

View reviewed changes

rjyounes requested changes Sep 25, 2022

View reviewed changes

rjyounes self-requested a review September 28, 2022 12:30

uscholdm commented Sep 28, 2022

View reviewed changes

rjyounes changed the title ~~Tasks and templates. Fixes #590.~~ Tasks and templates. Fixes #590, fixes #408. Sep 29, 2022

rjyounes force-pushed the issue-590-tasks-and-templates branch from 5929c53 to 942c4ce Compare October 1, 2022 20:22

rjyounes requested changes Oct 1, 2022

View reviewed changes

uscholdm requested a review from rjyounes October 3, 2022 16:24

rjyounes requested changes Oct 5, 2022

View reviewed changes

uscholdm and others added 11 commits October 5, 2022 15:04

Add scope notes and altLabels to task classes

9226104

Issue 590 - update annotation

f2f523a

Tweaked more annotations

15d8b9e

Tewaked annotation

af7396a

Add: uniqueText domainIncludes gist:Text

71a54be

Rename Task to TaskExecution and tweak annotations

9ca1569

Update annotations for Template (Issue #408)

Renamed Project to ProjectExecution

0051890

Rename ScheduledTask to ScheduledTaskExecution

5743660

Add stub deprecated file that should never be removed.

2c83a69

Add original definitions of Task, Project and ScheduledTask to the de…

6b31c04

…precated file.

Tweaked annotations

f29d34d

uscholdm and others added 8 commits October 5, 2022 15:05

Tweaked annotation

8f33dce

Added annotation to TaskTemplate

727155f

Remove suprefluous altLabel

38a5c51

Remove unneeded annotations and tweak other annotations.

83d8c83

Added one comma and removed one comma

ba03e5e

Tweaked annotation; Added release notes

a7ba6a3

Add backticks around class names in release notes

80f69b3

Fix release notes

a1cc4b9

rjyounes force-pushed the issue-590-tasks-and-templates branch from 1c4fba2 to a1cc4b9 Compare October 5, 2022 19:13

rjyounes self-requested a review October 5, 2022 19:17

rjyounes approved these changes Oct 5, 2022

View reviewed changes

rjyounes merged commit 85f28d0 into develop Oct 5, 2022

rjyounes deleted the issue-590-tasks-and-templates branch October 5, 2022 19:18

uscholdm mentioned this pull request Nov 9, 2023

TaskTemplate definition #408

Closed

Tasks and templates. Fixes #590, fixes #408. #691

Tasks and templates. Fixes #590, fixes #408. #691

Uh oh!

Conversation

uscholdm commented Jun 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uscholdm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rjyounes commented Sep 29, 2022

Uh oh!

uscholdm commented Sep 30, 2022

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjyounes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjyounes commented Oct 5, 2022

Uh oh!

Uh oh!