-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tree depth constants to JavaScript libraries and Solidity contracts #711
Conversation
Add tree depth constants to JavaScript libraries and Solidity contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽 I left just a comment.
@gitpoap-bot @0xbok @0xDatapunk |
Congrats, @0xbok @0xDatapunk ! You've earned a GitPOAP for your contribution! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
wowow, thanks @aguzmant103 :) |
Amazing!
On Mar 18, 2024, at 10:30 AM, 0xbok ***@***.***> wrote:
wowow, thanks @aguzmant103<https://github.com/aguzmant103> :)
—
Reply to this email directly, view it on GitHub<#711 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AU3UMTQEADKX7XMUP4QKI3LYY33A7AVCNFSM6AAAAABEX6YKUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGA3TIMJTGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…nstants Add tree depth constants to JavaScript libraries and Solidity contracts Former-commit-id: d256905
Description
This PR adds tree depth constants to JavaScript libraries and Solidity contracts to follow good practices and make it easier to update these important values.
There is a new export in the
@semaphore-protocol/utils
library calledconstants
which has the minimum and maximum Semaphore supported tree depth.There is a new file called
Constants.sol
in thepackages/contracts/contracts/base
folder which has the minimum and maximum Semaphore supported tree depth.With these updates, when the supported tree depths change, only these two files should be updated with the
VK_POINTS
variable in theSemaphoreVerifier.sol
contract.Related Issue(s)
Closes #683
Checklist
yarn prettier
andyarn lint
without getting any errors