feat(notifications): Support for tags #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 📝 Description - refreshes protos - adds tag field in notifications form <img width="416" height="164" alt="image" src="https://github.com/user-attachments/assets/8d892f05-936b-4a32-9d62-716d81f32c13" /> ## ✅ Checklist - [x] I have tested this change - [ ] This change requires documentation update
) ## 📝 Description - refresh protos - implement the updated API semaphoreci/api#39 (this API is also used by `front`) - adds the filtering by tag rule if `git_ref_type == :TAG` so both branch and tag rules can be defined in same notification ## ✅ Checklist - [ ] I have tested this change - [ ] This change requires documentation update
hamir-suspect
changed the title
…otifications (#596) ## 📝 Description Refreshes protos in `public-api-gateway` to add support for tags in notifications. Upgrade versions in `public-api-gateway`. A small fix in `notifications` service ## ✅ Checklist - [x] I have tested this change - [ ] This change requires documentation update
hamir-suspect
requested review from
lucaspin,
VeljkoMaksimovic,
DamjanBecirovic,
skipi and
forestileao
as code owners
skipi
approved these changes
Sep 22, 2025
DamjanBecirovic
approved these changes
Sep 22, 2025
lucaspin
approved these changes
Sep 22, 2025
2 tasks
hamir-suspect
added a commit
that referenced
this pull request
Sep 23, 2025
## 📝 Description For task runs there is no hook -> failed processing of pipeline finished message, this fixes the issue and takes if possible tag and pr names from hook, otherwise falls back to pipeline data. #### `logs` ``` INFO 2025-09-22T15:18:44.605829774Z [resource.labels.containerName: notifications] ** (UndefinedFunctionError) function nil.git_ref_type/0 is undefined INFO 2025-09-22T15:18:44.605831724Z [resource.labels.containerName: notifications] nil.git_ref_type() INFO 2025-09-22T15:18:44.605834104Z [resource.labels.containerName: notifications] (notifications 0.1.0) lib/notifications/workers/coordinator.ex:29: anonymous fn/1 in Notifications.Workers.Coordinator.PipelineFinished.handle_message/1 ``` this issue was present before #591 was merged also: ``` INFO 2025-09-22T12:33:05.523589599Z [resource.labels.containerName: notifications] ** (UndefinedFunctionError) function nil.pr_branch_name/0 is undefined INFO 2025-09-22T12:33:15.596608567Z [resource.labels.containerName: notifications] ** (UndefinedFunctionError) function nil.pr_branch_name/0 is undefined INFO 2025-09-22T12:33:25.758473405Z [resource.labels.containerName: notifications] ** (UndefinedFunctionError) function nil.pr_branch_name/0 is undefined ``` ## ✅ Checklist - [x] I have tested this change - [ ] This change requires documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Feature branch for: #369
notificationsfront)git_ref_type == :TAGso both branch and tag rules can be defined in same notificationfrontpublic-api-gatewayRefreshes protos in to add support for tags in notifications.
Pin protobuf tooling versions since
@latestis now broken✅ Checklist