fix api breaking of google/go-github #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google/go-github broke the api of their functions with google/go-github@23d6cb9 This commit adds the context `context.TODO()` to the call of `gh.Repositories.ListReleases` which is meant to be used "when it's unclear which Context to use or it is not yet available (because the surrounding function has not yet been extended to accept a Context parameter)" (citing https://godoc.org/context) Signed-off-by: julian <dev@jneureuther.de>
|
@matejkramny I would propose to do at least a hotfix release (2.1.1) after this is merged in order to have a release that builds. |
|
Thanks Julian. I'll produce a release in the next 48hrs |
Thank you! This will be really helpful for everyone that uses semaphore by builting the latest release from source. 🙂 |
|
Sure, I might try to automate it as it's a little tedious.. There's also another PR which should be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google/go-github broke the api of their functions with google/go-github@23d6cb9
This PR adds the context
context.TODO()to the call ofgh.Repositories.ListReleaseswhich is meant to be used "when it's unclear which Context to use or it is not yet available (because the surrounding function has not yet been extended to accept a Context parameter)" (citing https://godoc.org/context)I chose this way because AFAIK we don't have much use of the
contextpackage.fixes #267