-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SweetAlert confirmation popup #509
Conversation
@zarianec Invalid indentation style, you should use tabs instead of spaces. |
I think using angular wrapper for sweetalert is more preferable: |
Hi @fiftin, we are just discussing that in discord. Why tabs instead of spaces if spaces is widely used and is, de facto, standard for styling js code. |
Tabs used in this project initially. The question should be addressed to @twhiston. |
Ok, i will convert spaces to tabs and open another issue related to code style. |
@zarianec thanks, that would be great. Let's pick a common and well know style guide in the new issue you create and then enforce it through the ci pipeline |
ii'll merge this and we can address angular wrapper stuff and style guide separately. Thanks |
Related to #507