Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SweetAlert confirmation popup #509

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Conversation

zarianec
Copy link
Contributor

Related to #507

@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@semaphoreui semaphoreui deleted a comment Mar 27, 2018
@fiftin
Copy link
Collaborator

fiftin commented Mar 28, 2018

@zarianec Invalid indentation style, you should use tabs instead of spaces.

@fiftin
Copy link
Collaborator

fiftin commented Mar 28, 2018

I think using angular wrapper for sweetalert is more preferable:

https://gist.github.com/pranav7/d075f7cd8263159cf36a

@zarianec
Copy link
Contributor Author

Hi @fiftin, we are just discussing that in discord. Why tabs instead of spaces if spaces is widely used and is, de facto, standard for styling js code.
Angular uses 2 spaces as indentation. Also there is a style guides from google and airbnb that suggests using 2 spaces for indentation.
Airbnb JavaScript Style Guide

@fiftin
Copy link
Collaborator

fiftin commented Mar 28, 2018

Tabs used in this project initially. The question should be addressed to @twhiston.

@zarianec
Copy link
Contributor Author

Ok, i will convert spaces to tabs and open another issue related to code style.

@twhiston
Copy link
Contributor

@zarianec thanks, that would be great. Let's pick a common and well know style guide in the new issue you create and then enforce it through the ci pipeline

@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@semaphoreui semaphoreui deleted a comment Mar 29, 2018
@twhiston
Copy link
Contributor

twhiston commented Apr 3, 2018

ii'll merge this and we can address angular wrapper stuff and style guide separately. Thanks

@twhiston twhiston merged commit 123a4ea into semaphoreui:develop Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants