Add back ENV support to environment #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiftin
force-pushed
the
develop
branch
2 times, most recently
from
0c60a1b
to
d3dfbf0
Compare
|
Hi @dpskvn, I sure we should have another place for environment variables. Perhaps additional textarea for it. |
|
@fiftin The environmental variables are a now a separate text area inside the Environment section. The new database model also reflects that. |
|
Thank you @dpskvn , LGFM, but after merge I will make refactoring to support YAML format instead of JSON (I will rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a re-implementation of #458 which was dropped in version 2, I believe.
As discussed here: #951, this would cover the scenarios where the dynamic inventory requires a token passed as an environment variable and if you have several accounts (which have different tokens), hard-coding it in the unit file is not an option.
I'm open to suggestions/comments. I know the contributing guidelines say there should be an issue opened first, but there is already one which I mentioned in the previous paragraph and there have been no replies to it.