Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : PDO::exec returns a false equivalent #157

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

dev-quentin
Copy link
Contributor

@dev-quentin dev-quentin commented Aug 5, 2024

Hello,

Correction of an incorrect comparison in ARC2_StoreSelectQueryHandler.php:

if (false == $this->store->a['db_object']->exec('INSERT INTO '.$tbl.' '."\n".$q_sql)) {

The PDO::exec function returns false on error, so === should be used instead of ==.


Solve issue: #156 (comment)

@k00ni k00ni linked an issue Aug 6, 2024 that may be closed by this pull request
@k00ni k00ni added store Related to the RDF store. fix labels Aug 6, 2024
@k00ni
Copy link
Collaborator

k00ni commented Aug 6, 2024

Thank you @dev-quentin. I am busy currently and don't know when I can have a look into that, but I will try. Ignore the failing coding style check, I probably fix them in a separate PR.

@dev-quentin
Copy link
Contributor Author

Thank you, @k00ni. This is my first pull request 😀.
If you correct the coding style in another pull request, should I close this request, or will you do it?

@k00ni
Copy link
Collaborator

k00ni commented Aug 6, 2024

If you correct the coding style in another pull request, should I close this request, or will you do it?

I will fix the coding styles in a separate pull request and merge it into master afterwards. This PR stays open, you don't have to do anything about the coding style issues. This way we don't pollute your fix and keep things clear.

@k00ni k00ni merged commit 702d7b1 into semsol:master Aug 16, 2024
40 of 41 checks passed
@k00ni
Copy link
Collaborator

k00ni commented Aug 16, 2024

Thank you @dev-quentin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix store Related to the RDF store.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDO::exec returns a false equivalent
2 participants