Avoid transforming #/guide links in guides.

Previously these old-style links were rendered disfunctional.
senchalabs · May 24, 2013 · e4deaa1 · e4deaa1
1 parent 95a052f
commit e4deaa1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/jsduck/guide_anchors.rb b/lib/jsduck/guide_anchors.rb
@@ -8,7 +8,7 @@ module JsDuck
   class GuideAnchors
 
     def self.transform(html, guide_name)
-      html.gsub(/(<a\s+(?:[^<>]*\s+)?href=['"]#)([^!].*?)(['"])/i) do |m|
+      html.gsub(/(<a\s+(?:[^<>]*\s+)?href=['"]#)([^!\/].*?)(['"])/i) do |m|
         "#{$1}!/guide/#{guide_name}-section-#{$2}#{$3}"
 
       end.gsub(/(<a\s+(?:[^<>]*\s+)?name=['"])(.*?)(['"])/i) do |m|

diff --git a/spec/guide_anchors_spec.rb b/spec/guide_anchors_spec.rb
@@ -26,11 +26,16 @@ def transform(html)
       "<a href='http://example.com'>label</a>"
   end
 
-  it "doesn't transform docs-app #! links " do
+  it "doesn't transform docs-app #! links" do
     transform("<a href='#!/api/Ext.Base'>Ext.Base</a>").should ==
       "<a href='#!/api/Ext.Base'>Ext.Base</a>"
   end
 
+  it "doesn't transform docs-app (backwards-compatible) # links" do
+    transform("<a href='#/api/Ext.Base'>Ext.Base</a>").should ==
+      "<a href='#/api/Ext.Base'>Ext.Base</a>"
+  end
+
   it "transforms anchors" do
     transform("<a name='blah'>target</a>").should ==
       "<a name='myguide-section-blah'>target</a>"